Fix gometalinter issues #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See, $ gometalinter --disable-all --enable golint | grep under hosts_test.go:14:2:warning: don't use underscores in Go names; const hosts_get should be hostsGet (golint) hosts_test.go:103:2:warning: don't use underscores in Go names; const hosts_remove should be hostsRemove (golint) maintenances_test.go:15:2:warning: don't use underscores in Go names; const maintenance_get should be maintenanceGet (golint) maintenances_test.go:52:2:warning: don't use underscores in Go names; const maintenances_remove should be maintenancesRemove (golint) maintenances_test.go:66:2:warning: don't use underscores in Go names; const maintenance_create should be maintenanceCreate (golint) zabbix_issue18_test.go:13:2:warning: don't use underscores in Go names; const issue18_data should be issue18Data (golint) Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
See, $ gometalinter --disable-all --enable golint | grep -v comment responses.go:34:6:warning: type ResponseApiVersion should be ResponseAPIVersion (golint) zabbix.go:163:23:warning: method GetApiVersion should be GetAPIVersion (golint) Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
See, warning: Errors unhandled.,LOW,HIGH (gosec) Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
See, $ gometalinter --disable-all --enable vet item.go:42:3:error: unreachable code (vet) zabbix.go:593:3:error: unreachable code (vet) Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
|
Hey! Thanks for the contribution! No idea how I missed that 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kovetskiy,
I fixed here some trivial issues, in separated commits, so that I can drop some if you do not like it.
BTW I moved some unhandled messages to the debug output.
Thanks!