list web scenarios as well as web items #4
Conversation
| "time" | ||
| ) | ||
|
|
||
| type HTTPTestStep struct { |
There was a problem hiding this comment.
can you please add doc to this structures? they have ambigious names (associated with some test purposes for me)
| @@ -225,6 +225,18 @@ func (zabbix *Zabbix) GetItems(params Params) ([]Item, error) { | |||
| return response.Data, nil | |||
| } | |||
|
|
|||
| func (zabbix *Zabbix) GetHTTPTests(params Params) ([]HTTPTest, error) { | |||
| debugln("* retrieving web checks list") | |||
There was a problem hiding this comment.
web checks -> web scenarios, I guess
| if err != nil { | ||
| return hierr.Errorf( | ||
| err, | ||
| "can't obtain zabbix webchecks", |
| params := Params{ | ||
| "hostids": identifiers, | ||
| } | ||
|
|
||
| var items []Item | ||
| err = withSpinner( |
There was a problem hiding this comment.
can you please place this operations (items and web scenarios) into goroutines and run it in parallel mode?
| errs <- err | ||
| }() | ||
|
|
||
| for _, err := range []error{<-errs, <-errs} { |
There was a problem hiding this comment.
why not just for err := range errs?
There was a problem hiding this comment.
I am talking about the second part of range, why there is such ambigious statement as []error{<-errs, <-errs}, why not just range errs?
There was a problem hiding this comment.
@kovetskiy: because range errs will never end. Range over channel waits till channel is closed, which will never happen in that case.
|
Thanks! |
No description provided.