Fix enhancement #190009: Width of custom date columns. #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two changes: 1) the 'today' and 'clear' buttons for date columns are now right adjusted. 2) Labels are now fixed width. Word wrap is disabled. There are two new tweaks to set the fixed widths for edit metadata single and bulk.
|
Maybe use QFontMetrics::averageCharWidth() for performance rather than calculating the width of a string of n's. Or if you do want to use a string of n's them maybe use m instead as that corresponds to the tradition 'em' unint. |
|
Changed to use averageCharWidth(). This is smaller than an 'n' so I bumped the default width in the tweak up by 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes:
the 'today' and 'clear' buttons for date columns are now right adjusted.
Labels are now fixed width. Word wrap is disabled. There are two new tweaks to
set the fixed widths for edit metadata single and bulk.