Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background color of wide glyphs #1455

Closed
jmriego opened this issue Mar 11, 2019 · 2 comments
Closed

Background color of wide glyphs #1455

jmriego opened this issue Mar 11, 2019 · 2 comments

Comments

@jmriego
Copy link

jmriego commented Mar 11, 2019

This is related to the issue #467. I'm using airline for vim and tmux instead of powerline but this would probably happen with any custom status line.

My issue is that I have a two different backgrounds color separated by a double-width glyph. After that glyph, there is a space (so it's detecting correctly that is a ligature and thus a wide glyph). The next space should be in a different background color but it's not doing so because of the special case that was introduced for powerline in #467.

airline

I was thinking of several solutions such as not doing that special case of duplicating the colors unless the change is exactly in the next space to the glyph. Probably the easiest way would be just to do the copy of the foreground color as the code is doing now but don't making any changes to the background color. That seems to work for both powerline and any custom line I have thought of

@jmriego
Copy link
Author

jmriego commented Mar 11, 2019

Thanks a lot @kovidgoyal ! I agree with the comment in the code about powerline though 😆

@kovidgoyal
Copy link
Owner

Yeah I put that comment there coz I was annoyed at the time I had to make the workaround. But it is not nice to call someone else's hard work stupid, I need to learn to be nicer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants