Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmux 3.2-rc2 fails to show truecolor under kitty, despite 3.1b working #3018

Closed
mfontani opened this issue Oct 8, 2020 · 4 comments
Closed
Labels

Comments

@mfontani
Copy link

mfontani commented Oct 8, 2020

Describe the bug

Using the bog-standard configuration of both tmux and (latest) kitty, tmux 3.1b properly shows a truecolor bar, whereas tmux 3.2-rc2 does not.

I think I've traced/bisected this to 2ab6f57, and specifically this part:

+    # Set RGB foreground color (non-standard used by neovim)
+    'setrgbf': r'\E[38:2:%p1%d:%p2%d:%p3%dm',
+    # Set RGB background color (non-standard used by neovim)
+    'setrgbb': r'\E[48:2:%p1%d:%p2%d:%p3%dm',

If I clone the kitty repo, comment-out those, ./build-terminfo and copy the resulting updated xterm-kitty file in my home's location, all works in all tmux versions. That's what I'm doing right now but feels icky. I'd like to understand what/who is causing which problem - tmux or kitty. Right now my guess is kitty, as undoing that recent change fixes things.

To Reproduce

I've created a Github repo containing all repro steps - from downloading and building the two versions of tmux, to running kitty in a docker container and showing the problem. You can find it at https://github.com/mfontani/tmux-kitty-colors-bug

Expected behavior

A truecolor "bar" ought to be showable under both terminals, but isn't.

Screenshots

@mfontani mfontani added the bug label Oct 8, 2020
@kovidgoyal
Copy link
Owner

That commit is over two years old, first appearing in kitty version
0.8.0. You are saying that tmux 3.1b works and tmux 3.2 doesn't, seems
pretty clear the bug is in tmux.

Report it to tmux, or better yet, stop using terminal multiplexers, they
are a plague: #391 (comment)

@mfontani
Copy link
Author

mfontani commented Oct 9, 2020

If someone ends up here looking for a fix, I think I've found one on the tmux side:

set-option -as terminal-features ',xterm-kitty:RGB'

The above setting works on tmux 3.2-rc2 but is a "new" option that cannot be set on 3.1b.

@trygveaa
Copy link
Sponsor Contributor

I reported it to tmux, it's been fixed now: tmux/tmux#2418

@kovidgoyal
Copy link
Owner

kovidgoyal commented Oct 13, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants