Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts in window shading after changing border type in sway #3888

Closed
bhepple opened this issue Jul 30, 2021 · 4 comments
Closed

Artifacts in window shading after changing border type in sway #3888

bhepple opened this issue Jul 30, 2021 · 4 comments
Labels

Comments

@bhepple
Copy link

bhepple commented Jul 30, 2021

Describe the bug
There are artifacts in the window shading after changing the border type in sway.

To Reproduce
Steps to reproduce the behavior:

  1. Open a fresh kitty instance
  2. Change border type with
swaymsg 'border toggle'
  1. Toggle between floating and regular containers
swaymsg 'floating toggle'
  1. Repeat 2. and 3. (depending on what your window's starting state is)
  2. You may also need to
swaymsg 'floating enable, resize set 700 900, move position center, border normal'
  1. Artifacts appear

Screenshots
image

Environment details

kitty 0.21.2 created by Kovid Goyal
Linux achar 5.12.13-200.fc33.x86_64 #1 SMP Wed Jun 23 16:20:26 UTC 2021 x86_64
\S
Kernel \r on an \m (\l)
Running under:Wayland
Loaded config files:
  /home/bhepple/.config/kitty/kitty.conf

Config options different from defaults:
allow_remote_control    y
focus_follows_mouse     True
font_size               10.0
listen_on               unix:/tmp/kitty-socket
selection_background    Color(red=221, green=221, blue=221)
tab_bar_edge            1
tab_bar_min_tabs        1
tab_bar_style           powerline
touch_scroll_multiplier 16.0
Added shortcuts:
	shift+page_up KeyAction('scroll_page_up')
	shift+page_down KeyAction('scroll_page_down')
	shift+ctrl+f1 KeyAction('launch', ('xdg-open', 'https://sw.kovidgoyal.net/kitty'))
Changed shortcuts:
	shift+ctrl+0 KeyAction('change_font_size', (True, None, 0.0))
	shift+ctrl+tab KeyAction('prev_tab')

Additional context
Also happens with 'kitty --config NONE'

CPU: Quad Core Intel Core i7-2630QM (-MT MCP-) speed/min/max: 1516/800/2900 MHz
Kernel: 5.12.13-200.fc33.x86_64 x86_64

sway-1.6-1.fc34.x86_64
wlroots-0.13.0-1.fc34.x86_64
kitty-0.21.2-1.fc34.x86_64

@bhepple bhepple added the bug label Jul 30, 2021
@kovidgoyal
Copy link
Owner

kitty doesn't support turning client side decorations on and off, which
is what border toggle in sway appears to do. If you really need this
functionality for some reason, patches are welcome. Relevant code is in
glfw/wl*

@bhepple
Copy link
Author

bhepple commented Jul 31, 2021

So I now need to script around 'border csd'. Here's what I came up with - sway-border-tweak. I bindsym it to $mod+k so I can adjust borders in-flight.

kovidgoyal added a commit that referenced this issue Jul 31, 2021
Draw CSD if the compositor wants us to. See #3888
@kovidgoyal
Copy link
Owner

Actually, this should take care of it:
6bfb704

at least it seems to work in my basic testing on sway.

@bhepple
Copy link
Author

bhepple commented Jul 31, 2021

Thanks for that - impressively fast turnaround!! I'll try to build and test later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants