[fish shell integration] repaint removes text printed by fish key binding

[iacore]

Describe the bug
text printed by keybind in fish disappear when screen is repaint (such as resizing the window)

To Reproduce
Steps to reproduce the behavior:

1. open new window with kitty --config NONE fish
2. run bind \eg 'echo; git status; git remote -v; echo; commandline -f repaint'
3. press Alt+g in a git repo
4. resize the window to be wider or narrower (in width)

Screenshots

The screenshots below show the whole window width.

After git init, I pressed Alt+g, and git information is shown.

Then, I resize the kitty window to be wider, and the git info text is gone, leaving an empty space.

Environment details

❯ kitty --version
kitty 0.31.0 created by Kovid Goyal

❯ fish --version
fish, version 3.6.4

Additional context

Ctrl+Shift+G (show last command output in pager) ignores the output printed by fish keybind. I think this is the appropriate behavior.

Can reproduce with kitty --config NONE. Latest fish version (3.7.0) probably works too.

The issue is first discussed in fish-shell/fish-shell#10289.

[iacore]

I have "fixed" the problem by calling __ksi_mark_prompt_start at the end.

e.g. bind \eg 'echo; git status; git remote -v; echo; commandline -f repaint; __ksi_mark_prompt_start'

commandline -f repaint is recommended by fish documentation. I guess the fish_prompt event is not fired after commandline -f repaint.

[kovidgoyal]

I dont know of anyway to fix this. If commandline -f repaint doesnt run
the prompt marking hooks, there is nothing the shell integration script
can do about it. Really, the correct fix for this is for fish to
implement prompt marking itself instead of every terminal emulator
having to write a script for it.