Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When only r or c is specified, the behavior is still strange #7479

Closed
sergei-grechanik opened this issue May 27, 2024 · 2 comments
Closed

When only r or c is specified, the behavior is still strange #7479

sergei-grechanik opened this issue May 27, 2024 · 2 comments
Labels

Comments

@sergei-grechanik
Copy link
Contributor

This is related to #7380 and #6979
Right now the aspect ratio of the image is preserved, but the missing dimension size in cells is not computed to fit the image. For example, using the mars image from #7380:
image

This is worse when the image is scaled up. When running the script from #6979:
image

I'm assuming this is not the intended behavior.

@kovidgoyal
Copy link
Owner

I dont understand. If you specify only c=50 then the image is displayed in the appropriate number of rows so that it takes 50 columns but preserves its aspect ratio. See screenshot. If the number of rows were computed ignoring the value of c, then the aspect ratio would not be preserved. What are you expecting to happen?
screenshot

@sergei-grechanik
Copy link
Contributor Author

It's about cursor movement, the number of rows/columns by which the cursor is moved doesn't match the number of rows/columns of the image.

sergei-grechanik added a commit to sergei-grechanik/st-graphics that referenced this issue May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants