Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a default socket timeout when retrieving remote items in icat. #2644

Merged
merged 1 commit into from May 11, 2020
Merged

Set a default socket timeout when retrieving remote items in icat. #2644

merged 1 commit into from May 11, 2020

Conversation

lamby
Copy link
Contributor

@lamby lamby commented May 11, 2020

Otherwise we can easily hang when "icat"-ing resources from unreliable websites/webcams, etc.

@Luflosi
Copy link
Contributor

Luflosi commented May 11, 2020

I think def socket_timeout(seconds: int) -> None: instead of def socket_timeout(seconds): should fix the CI error.

Otherwise we can easily hang when "icat"-ing resources from unreliable
websites/webcams, etc.
@lamby
Copy link
Contributor Author

lamby commented May 11, 2020

I think def socket_timeout(seconds: int) -> None: instead of def socket_timeout(seconds): should fix the CI error

Ahh, thanks. Force-pushed for clarity. 👍

@kovidgoyal kovidgoyal merged commit e39da2b into kovidgoyal:master May 11, 2020
@lamby lamby deleted the icat-http-timeout branch May 31, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants