Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS-window resizing #3788

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

williamspatrick
Copy link

No description provided.

@williamspatrick
Copy link
Author

williamspatrick commented Jul 2, 2021

See #3785 for original PR and design discussion.

Intended work tasks / progress:

  • CSI escape codes
    • Add option for escape codes.
    • Basic CSI 4/8 support for resizing single window (OS window).
    • CSI 4/8 support for multiple windows (resize + reflow layout).
    • Ensure minimum size windows are handled for CSI 4/8.
    • CSI 9/10 support for full screen and maximize.
    • CSI 88 support for OS window-only resize (using CSI 4/8 support).
    • CSI 89 support for kitty window-only resize (using CSI 4/8 support).
  • kitty +kitten @ resize-os-window implementation
  • Fix any High DPI issues on macOS

@kovidgoyal
Copy link
Owner

You also need to fix the high dpi issue on macOS, I think.

@williamspatrick williamspatrick force-pushed the csi-resize branch 3 times, most recently from 66674f3 to 492b134 Compare July 7, 2021 13:50
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Add support in the parser for codes 88 and 89, which are intended
to be like 8 but only resize the os-window or layout-window
respectively.  Currently, these behave exactly like 8, but the
parsing logic is in place to pick apart the behavioral aspects
and pass it into window.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
@kovidgoyal
Copy link
Owner

I have implemented the remote control command for this. That should give you all the lower level pieces to implement the rest of it easily.

@TheArcaneBrony
Copy link

Concern: how would this be handled in tiling window managers? There is a way to disable this, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants