Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that suggestion doesn't remove any parts of the line #79

Closed
vrom911 opened this issue Aug 25, 2019 · 0 comments · Fixed by #92
Closed

Make sure that suggestion doesn't remove any parts of the line #79

vrom911 opened this issue Aug 25, 2019 · 0 comments · Fixed by #92
Assignees
@vrom911
Labels
HLint
Milestone
v0.0.0.0: Initial...

Comments

@vrom911
Copy link
Member

vrom911 commented Aug 25, 2019

In HLint the Idea stores the SrcLoc of the corresponding code of the hint, so we should make sure that we make the suggestion only to the corresponding part and leave the rest as it is.
@vrom911 vrom911 added the HLint label Aug 25, 2019
@chshersh chshersh added this to the v0.0.0.0: Initial release milestone Aug 27, 2019
@vrom911 vrom911 self-assigned this Sep 1, 2019
vrom911 added a commit that referenced this issue Oct 3, 2019
@vrom911
[#79] Make sure that suggestion doesn't remove any parts of the line
5571bb0 
Resolves #79
@vrom911 vrom911 mentioned this issue Oct 3, 2019
Merged
vrom911 added a commit that referenced this issue Oct 3, 2019
@vrom911
[#79] Make sure that suggestion doesn't remove any parts of the line
50b6aa5 
Resolves #79
chshersh pushed a commit that referenced this issue Oct 3, 2019
@vrom911 @chshersh
[#79] Make sure that suggestion doesn't remove any parts of the line (#…
0ec8d92 
…92)

* [#79] Make sure that suggestion doesn't remove any parts of the line

Resolves #79

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrom911 vrom911

Labels
HLint
Projects
None yet
Milestone
v0.0.0.0: Initial release
Development

Successfully merging a pull request may close this issue.

[#79] Make sure that suggestion doesn't remove any parts of the line kowainik/hintman
2 participants
@chshersh @vrom911