Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing tests - Chapter 4, Tasks 3 and 5 #280

Closed
ansonmiu0214 opened this issue Oct 26, 2020 · 1 comment
Closed

Missing tests - Chapter 4, Tasks 3 and 5 #280

ansonmiu0214 opened this issue Oct 26, 2020 · 1 comment
Labels
wontfix This will not be worked on

Comments

@ansonmiu0214
Copy link

No tests for functor and applicative instances for List type.
ansonmiu0214 added a commit to ansonmiu0214/learn4haskell that referenced this issue Oct 26, 2020
@ansonmiu0214
Fix typo in Chapter4 tests (kowainik#280)
a81fc0b
ansonmiu0214 added a commit to ansonmiu0214/learn4haskell that referenced this issue Oct 26, 2020
@ansonmiu0214
Add tests for Chapter4 Task3 (kowainik#280)
4a30b7d
ansonmiu0214 added a commit to ansonmiu0214/learn4haskell that referenced this issue Oct 26, 2020
@ansonmiu0214
Add tests for Chapter4 Task5 (kowainik#280)
e383abd
ansonmiu0214 added a commit to ansonmiu0214/learn4haskell that referenced this issue Oct 26, 2020
@ansonmiu0214
Derive Show/Eq typeclasses for List in Chapter4 (kowainik#280)
eab1137
@vrom911
Copy link
Member

vrom911 commented Oct 27, 2020

@ansonmiu0214 Thanks for your input, but we did it on purpose. As there are no instances for them in code now, it will stop the project to build at all and there won't be possible to run any tests before people implement instances of Chapter 4 which is absolutely not acceptable.

@vrom911 vrom911 closed this as completed Oct 27, 2020
@vrom911 vrom911 added invalid This doesn't seem right wontfix This will not be worked on and removed invalid This doesn't seem right labels Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vrom911 @ansonmiu0214