Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#7] Add typeclasses law tests #24

Merged
merged 1 commit into from
Oct 10, 2020
Merged

[#7] Add typeclasses law tests #24

merged 1 commit into from
Oct 10, 2020

Conversation

chshersh
Copy link
Contributor

@chshersh chshersh commented Oct 10, 2020 •
edited

Only part of #7

@chshersh chshersh self-assigned this Oct 10, 2020
@chshersh chshersh added the tests Testing, property testing, DocTests label Oct 10, 2020
hint-man[bot]
hint-man bot reviewed Oct 10, 2020
View reviewed changes
Copy link

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why your PR is still not approved? Because I chose not to approve it. But they will.

test/Test/Prolens/Property.hs Show resolved Hide resolved
@chshersh chshersh force-pushed the chshersh/7-Add-typeclasses-law-tests branch from d33ba90 to 8c6a7e5 Compare October 10, 2020 15:51
vrom911
vrom911 approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🐬

test/Test/Prolens/Property.hs
Comment on lines +65 to +68
eqFun :: Fun Maybe Int Int -> Fun Maybe Int Int -> PropertyT IO ()
eqFun fun1 fun2 = do
x <- forAll genInt
unFun fun1 x === unFun fun2 x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever 🧠

@vrom911 vrom911 merged commit 559e106 into master Oct 10, 2020
@vrom911 vrom911 deleted the chshersh/7-Add-typeclasses-law-tests branch October 10, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hint-man hint-man[bot] hint-man left review comments

@vrom911 vrom911 vrom911 approved these changes

Assignees

@chshersh chshersh

Labels
tests Testing, property testing, DocTests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chshersh @vrom911