Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#28] Inspection tests for Prisms #48

Merged
merged 2 commits into from
Nov 4, 2020
Merged

[#28] Inspection tests for Prisms #48

merged 2 commits into from
Nov 4, 2020

Conversation

vrom911
Copy link
Member

@vrom911 vrom911 commented Nov 4, 2020

Resolves #28

@vrom911 vrom911 self-assigned this Nov 4, 2020
@vrom911 vrom911 added hacktoberfest help wanted Extra attention is needed tests Testing, property testing, DocTests labels Nov 4, 2020
hint-man[bot]
hint-man bot approved these changes Nov 4, 2020
View reviewed changes
Copy link

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no place for me here... I will choose the truth I like.

chshersh
chshersh approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Can't believe we've managed to fix this! 😍

test/Test/Data.hs Outdated
@@ -79,7 +80,7 @@ data Grade
deriving stock (Show, Eq)

_Mark :: Prism' Grade Int
_Mark = prism' Mark $ \case
_Mark = inline prism' Mark $ \case
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if removing this inline will still allow tests to pass 🤔

test/Test/Prolens/Inspection.hs
@@ -77,7 +77,7 @@ matchMarkManual grade = case grade of
prismSpecs :: Spec
prismSpecs = describe "Prism" $ do
describe "preview" $ do
xit "preview _Ctor x ≡ case (Ctor _) of" $
it "preview _Ctor x ≡ case (Ctor _) of" $
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice change! All for just removing a single letter 😅

@chshersh chshersh merged commit 63c7868 into master Nov 4, 2020
@chshersh chshersh deleted the vrom911/28-Inspection-tests-for-Prisms branch November 4, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chshersh chshersh chshersh approved these changes

@hint-man hint-man[bot] hint-man approved these changes

Assignees

@vrom911 vrom911

Labels
hacktoberfest help wanted Extra attention is needed tests Testing, property testing, DocTests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inspection tests for Prisms
2 participants
@vrom911 @chshersh