Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardise some Extra API #270

Closed
2 tasks
chshersh opened this issue May 11, 2020 · 1 comment · Fixed by #360
Closed
2 tasks

Standardise some Extra API #270

chshersh opened this issue May 11, 2020 · 1 comment · Fixed by #360
Assignees
@vrom911
Labels
question Further information is requested reexport Reexport something new
Milestone
v1.0.0.0: Officia...

Comments

@chshersh
Copy link
Contributor

relude exists for a while, so maybe it's time to move some of the Extra code to a stable API. I've noticed that I use some Extra functions in many places. We want to encourage best-practices, provide idiomatic conventions and names and don't conflict a lot with people.

Here are some candidates for moving to a stable API:

  • universe: maybe we can create a module Relude.Enum and put
  • inverseMap: I need it quite often

What other extra stuff people are using all the time? 🙂
@chshersh chshersh added question Further information is requested reexport Reexport something new labels May 11, 2020
@chshersh chshersh added this to the v0.8.0.0: Standard milestone May 11, 2020
@chshersh chshersh pinned this issue Jun 4, 2020
@chshersh chshersh removed this from the v0.8.0.0: Standard milestone Aug 16, 2020
@chshersh chshersh changed the title [RFC] Standardise some Extra API Standardise some Extra API Mar 9, 2021
@chshersh
Copy link
Contributor Author

chshersh commented Mar 9, 2021

Decided to move these two functions to the default namespace. I use them quite often, and making them available by default really improves the workflow.

@vrom911 vrom911 self-assigned this Mar 11, 2021
vrom911 added a commit that referenced this issue Mar 11, 2021
@vrom911
[#270] Standardise some Extra API
b04ddd6 
Resolves #270
@vrom911 vrom911 mentioned this issue Mar 11, 2021
Merged
@chshersh chshersh unpinned this issue Mar 11, 2021
chshersh added a commit that referenced this issue Mar 11, 2021
@vrom911 @chshersh
[#270] Standardise some Extra API (#360)
1e5fb60 
* [#270] Standardise some Extra API

Resolves #270

* Apply suggestions from code review

Co-authored-by: Dmitrii Kovanikov <kovanikov@gmail.com>

* Fix Monoid build on GHC versions

Co-authored-by: Dmitrii Kovanikov <kovanikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrom911 vrom911

Labels
question Further information is requested reexport Reexport something new
Projects
None yet
Milestone
v1.0.0.0: Official standard release
Development

Successfully merging a pull request may close this issue.

[#270] Standardise some Extra API kowainik/relude
2 participants
@chshersh @vrom911