Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ordNub using nubOrd from containers for better efficiency #346

Closed
chshersh opened this issue Feb 12, 2021 · 0 comments · Fixed by #352
Closed

Implement ordNub using nubOrd from containers for better efficiency #346

chshersh opened this issue Feb 12, 2021 · 0 comments · Fixed by #352
Assignees
@vrom911
Labels
enhancement New feature or request reexport Reexport something new
Milestone
v1.0.0.0: Officia...

Comments

@chshersh
Copy link
Contributor

The implementation from containers has some rewrite rules and other optimizations.

Additionally, we may want to reexport intNub using nubInt from containers.
@chshersh chshersh added enhancement New feature or request reexport Reexport something new labels Feb 12, 2021
@chshersh chshersh added this to the v0.8.0.0: Standard milestone Feb 12, 2021
@vrom911 vrom911 self-assigned this Mar 9, 2021
vrom911 added a commit that referenced this issue Mar 9, 2021
@vrom911
[#346] Implement ordNub using nubOrd from containers for better…
64f8519 
… efficiency

Resolves #346
@vrom911 vrom911 mentioned this issue Mar 9, 2021
Merged
vrom911 added a commit that referenced this issue Mar 9, 2021
@vrom911
[#346] Implement ordNub using nubOrd from containers for better…
520b749 
… efficiency

Resolves #346
chshersh pushed a commit that referenced this issue Mar 9, 2021
@vrom911
[#346] Implement ordNub using nubOrd from containers for better…
eaebe3e 
… efficiency (#352)

* [#346] Implement `ordNub` using `nubOrd` from `containers` for better efficiency

Resolves #346

* Add cpp on old GHC support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrom911 vrom911

Labels
enhancement New feature or request reexport Reexport something new
Projects
None yet
Milestone
v1.0.0.0: Official standard release
Development

Successfully merging a pull request may close this issue.

[#346] Implement ordNub using nubOrd from containers for better efficiency kowainik/relude
2 participants
@chshersh @vrom911