Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on usages ofreadFileText and writeFileText #372

Closed
chshersh opened this issue Mar 16, 2021 · 2 comments · Fixed by #407
Closed

Warn on usages ofreadFileText and writeFileText #372

chshersh opened this issue Mar 16, 2021 · 2 comments · Fixed by #407
Assignees
@chshersh
Labels
doc README, Haddock documentation, tutorials enhancement New feature or request
Milestone
v1.1.0.0: Safety ...

Comments

@chshersh
Copy link
Contributor

These functions are considered an anti-pattern. So probably a good idea not to re-export them and make them available by default.
@vrom911
Copy link
Member

vrom911 commented Mar 17, 2021

On the other hand, there is Text in the name. Maybe we can first add a warning?

@chshersh
Copy link
Contributor Author

@vrom911 That's a good idea, actually 👍🏻

@chshersh chshersh changed the title Don't reexport readFileText and writeFileText Warn on usages ofreadFileText and writeFileText Mar 17, 2021
@chshersh chshersh pinned this issue Nov 5, 2021
@chshersh chshersh self-assigned this Apr 14, 2022
chshersh added a commit that referenced this issue Apr 14, 2022
@chshersh
[#372] Warn on usages ofreadFileText and writeFileText
a9c519c 
Resolves #372
@chshersh chshersh mentioned this issue Apr 14, 2022
Merged
@chshersh chshersh added enhancement New feature or request doc README, Haddock documentation, tutorials and removed remove labels Apr 14, 2022
vrom911 pushed a commit that referenced this issue Apr 14, 2022
@chshersh
[#372] Warn on usages ofreadFileText and writeFileText (#407)
1cd9f2e 
Resolves #372
@chshersh chshersh unpinned this issue Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chshersh chshersh

Labels
doc README, Haddock documentation, tutorials enhancement New feature or request
Projects
None yet
Milestone
v1.1.0.0: Safety and maintenance
Development

Successfully merging a pull request may close this issue.

[#372] Warn on usages ofreadFileText and writeFileText kowainik/relude
2 participants
@chshersh @vrom911