Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mapToFst instead of zip to improve list fusion in inverseMap #194

Merged
merged 5 commits into from Sep 22, 2019

Conversation

josephcsible
Copy link
Contributor

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

src/Relude/Extra/Enum.hs Outdated Show resolved Hide resolved
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring!

CHANGELOG.md Outdated Show resolved Hide resolved
@josephcsible josephcsible changed the title Use mapToFst instead of zip to improve list fusion Use mapToFst instead of zip to improve list fusion in inverseMap Sep 21, 2019
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@vrom911 vrom911 merged commit 461c46f into kowainik:master Sep 22, 2019
@josephcsible josephcsible deleted the invmapfuse branch September 22, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants