Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#311] Add maybeAt, !!? with its arguments flipped #348

Merged
merged 1 commit into from Mar 6, 2021
Merged

[#311] Add maybeAt, !!? with its arguments flipped #348

merged 1 commit into from Mar 6, 2021

Conversation

dalpd
Copy link
Contributor

@dalpd dalpd commented Feb 21, 2021

Resolves #311

Hi @chshersh! This wasn't assigned to anyone so I thought I'd give it a go, hope that was OK.

As for the naming: I didn't use one of your suggestions and came up with maybeAt for this but let me know if you all would prefer one of the others in the list. AFAIKT this wouldn't cause any name conflicts so just left it under Relude.List.

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

@chshersh chshersh added the new Bring something new into library (add function or type or interface) label Feb 26, 2021
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalpd Thanks for the contribution! And docs are nice 👍🏻
I left one comment regarding the failing tests.

I think the maybeAt name is fine. It doesn't have conflicts with other functions on Hackage ✔️

src/Relude/List.hs Outdated Show resolved Hide resolved
@chshersh chshersh merged commit 27395f2 into kowainik:main Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new Bring something new into library (add function or type or interface)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add non-operator name for the !!?
2 participants