Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"export" -> "import" #370

Merged
merged 1 commit into from
Mar 24, 2021
Merged

"export" -> "import" #370

merged 1 commit into from
Mar 24, 2021

Conversation

eschnett
Copy link
Contributor

(Does this example actually work? Don't you have to say Text.Show in the instance declaration?)

(Does this example actually work? Don't you have to say `Text.Show` in the instance declaration?)
@chshersh
Copy link
Contributor

Hi @eschnett! Thanks for your contribution 👍🏻 I see that you've opened another PR with another typo. Can you submit all typos in a single PR? So it will be easier for us to review and merge all the changes at once 🙂

And regarding your question: the example actually works. We reexport the Show typeclass name, so you don't need to qualify it. And because of how Haskell scoping rules work, it's enough to export Text.Show qualified to get the show method of the typeclass.

@eschnett
Copy link
Contributor Author

Thanks for the explanation.

I've read the documentation, and I don't anticipate sending any more corrections. There's only one unmerged PR.

@chshersh chshersh merged commit 2573899 into kowainik:main Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants