Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future-proof re-exports from Data.Eq #391

Merged
merged 3 commits into from
Apr 4, 2022
Merged

Future-proof re-exports from Data.Eq #391

merged 3 commits into from
Apr 4, 2022

Conversation

Bodigrim
Copy link
Collaborator

@Bodigrim Bodigrim commented Nov 14, 2021

Resolves #390

I left CHANGELOG untouched, because there is currently no entry for unreleased changes, and I'm not sure whether this change requires an entry: it does not change anything for existing GHCs. Happy to add an entry, if you deem it worthwhile.

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

@Bodigrim
Copy link
Collaborator Author

https://github.com/kowainik/relude/runs/4206002297?check_suite_focus=true fails with unrelated doctest errors, while an earlier build https://github.com/kowainik/relude/runs/4179485378?check_suite_focus=true succeeds. The only difference is that the older build uses doctest-0.18.2 and the new one - freshly released doctest-0.20.

Restricting doctest < 0.19 seems to help.

@chshersh chshersh added the reexport Reexport something new label Apr 4, 2022
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chshersh chshersh merged commit 4e69f35 into kowainik:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reexport Reexport something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Future-proof re-exports from Data.Eq
2 participants