Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even if github integration is turned off, the changelog file contains links to github #122

Closed
ShrykeWindgrace opened this issue Aug 10, 2018 · 2 comments
Assignees
Labels
Git/Hub VCS issues

Comments

@ShrykeWindgrace
Copy link
Contributor

ShrykeWindgrace commented Aug 10, 2018

In a new project CHANGELOG.md contains

Change log
==========

ProjectName uses [PVP Versioning][1].
The change log is available [on GitHub][2].

0.0.0
=====
* Initially created.

[1]: https://pvp.haskell.org
[2]: https://github.com/RepositoryOwner/ProjectName/releases

if when I did

Add GitHub integration? [y]/n
  ->   n

during setup.

summon --version
1.0.6
@chshersh
Copy link
Contributor

@ShrykeWindgrace Thanks for feedback! It's quite possible to remove these tho lines from CHANGELOG.md when GitHub integration turned off.

The change log is available [on GitHub][2].
[2]: https://github.com/RepositoryOwner/ProjectName/releases

We can include this issue into the next release (version >= 1.0.7).

@chshersh chshersh added the Git/Hub VCS issues label Aug 10, 2018
@chshersh chshersh added this to the v1.1 Upgrade milestone Aug 10, 2018
@ShrykeWindgrace
Copy link
Contributor Author

That great, thank you=)

I guess the licence badge in README.md should also be affected by this toggle:

[![MIT license](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/RepositoryOwner/ProjectName/blob/master/LICENSE)

@willbasky willbasky self-assigned this Aug 24, 2018
willbasky added a commit that referenced this issue Aug 24, 2018
@willbasky willbasky mentioned this issue Aug 24, 2018
willbasky added a commit that referenced this issue Aug 24, 2018
chshersh pushed a commit that referenced this issue Aug 26, 2018
* [#122] Fix changelog and readme

* Fix readme

* Refactor readme

* Comprehanse it

* Add empty line

* Remove neat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Git/Hub VCS issues
Projects
None yet
Development

No branches or pull requests

3 participants