Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for summoning GHC 9.2.8, 9.4.5, and 9.6.2 #570

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

noughtmare
Copy link

@noughtmare noughtmare commented Jun 18, 2023

I've also updated the latest Stackage snapshots of 8.10.7 and 9.0.2.

@noughtmare noughtmare requested a review from vrom911 as a code owner June 18, 2023 14:45
@noughtmare noughtmare changed the title Add support for summoning GHC 9.2.8 and 9.4.5 Add support for summoning GHC 9.2.8, 9.4.5, and 9.6.2 Aug 10, 2023
@noughtmare
Copy link
Author

noughtmare commented Aug 10, 2023

@willbasky I've implemented your suggestion, thanks.

@vrom911 can you please review this?

@willbasky willbasky self-requested a review August 10, 2023 11:28
@willbasky
Copy link
Collaborator

@noughtmare The tests need the updates.

@noughtmare
Copy link
Author

I've used gg to update the golden tests.

@willbasky
Copy link
Collaborator

What a nice tool!

@noughtmare
Copy link
Author

It seems the CI also needed updating.

@noughtmare
Copy link
Author

Oh, of course summoner itself doesn't build on 9.6.2

@noughtmare
Copy link
Author

And that's blocked on shellmet, at least.

@willbasky
Copy link
Collaborator

Warning: Unknown/unsupported 'ghc' version detected (Cabal 3.6.2.0 supports 'ghc' version < 9.4): /home/runner/.ghcup/bin/ghc is version 9.6.2

< 9.4 yes, building summoner with 9.4.5 and 9.6.2 has no ways right now.

Also, instead of 9.2.4 we could build on 9.2.8

@noughtmare
Copy link
Author

noughtmare commented Aug 10, 2023

But if we can't build on 9.4.5 and 9.6.2 then we also can't test if summoning those versions work, except perhaps if we would build summoner with a different version of GHC than what we use to test the summoned project.

@willbasky
Copy link
Collaborator

Do the golden tests check if the 'project that is made with specific ghc in configs' is built with that ghc?
In other words:

  1. Summoner makes project with ghc version X.
  2. Tests tried to build made project.
    Is it?

@noughtmare
Copy link
Author

I think you're right that the tests only check things like 1, but then I don't understand why it did not work before I changed the CI. I'll revert that and we can try again.

@noughtmare
Copy link
Author

noughtmare commented Aug 10, 2023

Neat, the old results are still here.

Ah, so it's actually a separate CI action that tries to build the minimal project.

@willbasky
Copy link
Collaborator

If checks within 9.6.2 will pass then we could left checks for 9.4.5 too

@noughtmare
Copy link
Author

I've now added 9.4.5 too

@noughtmare
Copy link
Author

Now it should work...

@noughtmare
Copy link
Author

I've squashed the commits

@willbasky
Copy link
Collaborator

@noughtmare
Copy link
Author

noughtmare commented Aug 12, 2023

@willbasky there will be a 9.4.7 soon, so I think we should skip 9.4.6.

@Vekhir
Copy link

Vekhir commented Sep 12, 2023

Hi, GHC 9.4.7 is now available, and slated to be the final release of the 9.4 series. Anything blocking this from merging?

@Vekhir
Copy link

Vekhir commented Oct 7, 2023

@kowainik @vrom911 @noughtmare @willbasky What is the plan to proceed with this PR to enable summoner to support GHC 9.2, 9.4, and 9.6?
GHC 9.4.7 has been released, together with a new release 9.6.3.

A new version of summoner on Hackage would also be much appreciated, as it's needed for the Arch package

@noughtmare
Copy link
Author

@Vekhir I think this package has been abandoned. I'm personally not motivated enough to fork and initiate the package takeover process. So I think not much is going to change any time soon.

@Vekhir
Copy link

Vekhir commented Oct 7, 2023

Alright, thanks for your reply.

@willbasky
Copy link
Collaborator

willbasky commented Oct 7, 2023

@Vekhir Hi, I tried to message to @vrom911 in social media she didn't answer. As for me I haven't the right to merge here anything without second approval I guess. I am sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants