New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for summoning GHC 9.2.8, 9.4.5, and 9.6.2 #570
base: main
Are you sure you want to change the base?
Conversation
13accba
to
1a84038
Compare
@willbasky I've implemented your suggestion, thanks. @vrom911 can you please review this? |
@noughtmare The tests need the updates. |
I've used |
What a nice tool! |
1a1c758
to
f7094af
Compare
It seems the CI also needed updating. |
Oh, of course summoner itself doesn't build on 9.6.2 |
And that's blocked on shellmet, at least. |
< 9.4 yes, building summoner with 9.4.5 and 9.6.2 has no ways right now. Also, instead of |
But if we can't build on 9.4.5 and 9.6.2 then we also can't test if summoning those versions work, except perhaps if we would build summoner with a different version of GHC than what we use to test the summoned project. |
Do the golden tests check if the 'project that is made with specific ghc in configs' is built with that ghc?
|
I think you're right that the tests only check things like 1, but then I don't understand why it did not work before I changed the CI. I'll revert that and we can try again. |
f7094af
to
d50b371
Compare
Neat, the old results are still here. Ah, so it's actually a separate CI action that tries to build the minimal project. |
e8ee0f3
to
467c2c3
Compare
If checks within |
I've now added 9.4.5 too |
Now it should work... |
975b811
to
c45c02c
Compare
I've squashed the commits |
@willbasky there will be a 9.4.7 soon, so I think we should skip 9.4.6. |
Hi, GHC 9.4.7 is now available, and slated to be the final release of the 9.4 series. Anything blocking this from merging? |
@kowainik @vrom911 @noughtmare @willbasky What is the plan to proceed with this PR to enable summoner to support GHC 9.2, 9.4, and 9.6? A new version of |
@Vekhir I think this package has been abandoned. I'm personally not motivated enough to fork and initiate the package takeover process. So I think not much is going to change any time soon. |
Alright, thanks for your reply. |
I've also updated the latest Stackage snapshots of 8.10.7 and 9.0.2.