[#133] Patching EDSL for arrays of tables #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiegillet
changed the title
chshersh
requested review from
vrom911 and
chshersh
and removed request for
vrom911
chshersh
reviewed
Nov 15, 2018
src/Toml/Edsl.hs
Outdated
|
|
||
| -- | Adds array of tables to the 'TDSL'. | ||
| array :: Key -> NonEmpty TDSL -> TDSL | ||
| array k = modify . insertTableArrays k . fmap mkToml |
There was a problem hiding this comment.
I cant' think of better API for inserting array of tables, so let's keep this type and this implementation.
src/Toml/Edsl.hs
Outdated
| -- | Adds key-value pair to the 'TDSL'. | ||
| (=:) :: Key -> Value a -> TDSL | ||
| (=:) k v = modify $ insertKeyVal k v | ||
|
|
||
| -- | Adds table to the 'TDSL'. | ||
| table :: Key -> TDSL -> TDSL | ||
| table k = modify . insertTable k . mkToml | ||
|
|
||
| -- | Adds array of tables to the 'TDSL'. | ||
| array :: Key -> NonEmpty TDSL -> TDSL |
There was a problem hiding this comment.
I feel like array is not the best name because it conflicts with ordinary arrays in TOML.
vrom911
reviewed
Nov 16, 2018
src/Toml/Edsl.hs
Outdated
| @@ -9,20 +9,28 @@ exampleToml = mkToml $ do | |||
| \"key2\" =: Bool True | |||
| table \"tableName\" $ | |||
| \"tableKey\" =: Array [\"Oh\", \"Hi\", \"Mark\"] | |||
| array \"arrayName\" $ | |||
There was a problem hiding this comment.
I guess, it's also should be tableArray now?
There was a problem hiding this comment.
Of course, thank you!
chshersh
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #133
✅ Check list
hlint .output is: No Hints .stylish-haskelltoolusing [stylish-haskell.yaml][stylish] file in the repository.
Start the first line of the commit with the issue number in square parentheses.