Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement custom State #311

Closed
vrom911 opened this issue May 18, 2020 · 1 comment · Fixed by #316
Closed

Reimplement custom State #311

vrom911 opened this issue May 18, 2020 · 1 comment · Fixed by #316
Assignees
@vrom911
Labels
codec Conversion between TOML and custom user data types
Milestone
v1.3.0.0: Big update

Comments

@vrom911
Copy link
Member

vrom911 commented May 18, 2020

Now we don't have Reader anymore and the only thing that is blocking DerivingVia feature for generics is State. We can try to reimplement the custom one and see how it works for us.
@vrom911 vrom911 added the codec Conversion between TOML and custom user data types label May 18, 2020
@vrom911 vrom911 added this to the v1.3.0.0: Big update milestone May 18, 2020
@chshersh
Copy link
Contributor

As a bonus side-effect (and a proof-of-the-approach): we can implement diwrap using just coerce

@chshersh chshersh mentioned this issue May 18, 2020
Closed
@vrom911 vrom911 self-assigned this May 19, 2020
vrom911 added a commit that referenced this issue May 19, 2020
@vrom911
[#311] Reimplement custom State
4575446 
Resolves #311
@vrom911 vrom911 mentioned this issue May 19, 2020
Merged
chshersh pushed a commit that referenced this issue May 19, 2020
@vrom911
[#311] Reimplement custom State (#316)
c270a36 
* [#311] Reimplement custom State

Resolves #311

* Fix
dariodsa added a commit to dariodsa/tomland that referenced this issue Aug 5, 2020
@dariodsa
[kowainik#311] removed additional trailing spaces
0c12467
chshersh pushed a commit that referenced this issue Aug 13, 2020
@dariodsa
[#331] Hexidecimal value with underscore (#332)
38d74d3 
* [#331] adding test for hexadecimal representation

* [#331] adding test for octal representation

* [#331] adding test for binary representation with underscore

* [#331] corrected wrong types in function parseInteger

* [#331] add Data.Char module for ascii value and parsec modules for hex,oct and bin digits

* [#331] add more tests with underscore

* [#331] implemented parser for hex, oct and bin with underscore feature

* [#331] haskell style guide

* [#331] removed trailing spaces

* [#311] removed additional trailing spaces

* [#331] changed tests to check for exceptions and added new test group

* [#331] implemented parser for hex, oct and bin with underscore using megaparsec lib function

* [#331] added test cases that check when number ends with underscore

* [#331] resolved issues with code style and naming convention
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrom911 vrom911

Labels
codec Conversion between TOML and custom user data types
Projects
None yet
Milestone
v1.3.0.0: Big update
Development

Successfully merging a pull request may close this issue.

[#311] Reimplement custom State kowainik/tomland
2 participants
@chshersh @vrom911