[#50] Add decode.encode = id tests #173
Conversation
vrom911
added
codec
test/Test/Toml/BiCode/Property.hs
Outdated
| genInt = Gen.int (Range.constant 0 256) | ||
|
|
||
| genWord :: Gen Word | ||
| genWord = Gen.word (Range.constant 1 256) |
There was a problem hiding this comment.
You can use constantBounded generator for Int and Word to avoid specifying boundaries manually. Unfortunately, won't fork for Double and Float, they don't have instances...
There was a problem hiding this comment.
Thanks!
Also, do you think that it's better to move these generators to Gen module?
There was a problem hiding this comment.
@vrom911 Yeah, I think it's a good idea to move general-purpose generators (like genWord) into single module, because they are probably going to be reusable in several places (for example, I can see that BiMap.Property uses most of the same generators. It's a good idea to keep all basic generators in single place 🙂
| deriving (Show) | ||
|
|
||
| instance Eq BigTypeNewtype where | ||
| (BigTypeNewtype a) == (BigTypeNewtype b) = zonedTimeToUTC a == zonedTimeToUTC b |
There was a problem hiding this comment.
Very nice idea to move ZonedTime inside newtype! With this trick you can minimize the size of Eq instance and test both diwrap and zonedTime!
| , btText :: Text | ||
| , btString :: String | ||
| , btBS :: ByteString | ||
| , btLazyBS :: L.ByteString |
There was a problem hiding this comment.
Lol, I just noticed that in tomland we have Text, ByteString, LByteString and String but not LText. Heh, that's awkward. Probably need to add LText to tomland as well. I've created issue for this:
vrom911
force-pushed
the
vrom911/50-decode-encode
branch
from
02fefac
to
8a631b3
Compare
vrom911
changed the title
|
@kowainik/dev it's ready for review! |
| , genInteger | ||
| , genDouble |
There was a problem hiding this comment.
I like separation of reexports in this export section! 😍
Co-Authored-By: vrom911 <vrom911@gmail.com>
Resolves #50