Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#174] Add _LText and lazyText #176

Merged
merged 1 commit into from
Jan 11, 2019
Merged

[#174] Add _LText and lazyText #176

merged 1 commit into from
Jan 11, 2019

Conversation

vrom911
Copy link
Member

@vrom911 vrom911 commented Jan 11, 2019

Resolves #174

@vrom911 vrom911 added the codec Conversion between TOML and custom user data types label Jan 11, 2019
@vrom911 vrom911 self-assigned this Jan 11, 2019
chshersh
chshersh approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good to me 👍

src/Toml/Bi/Map.hs
@@ -297,6 +299,16 @@ _Double = mkAnyValueBiMap matchDouble Double
_Text :: TomlBiMap Text AnyValue
_Text = mkAnyValueBiMap matchText Text

-- | Helper bimap for 'Data.Text.Lazy.Text' and 'Data.Text.Text'.
_LTextText :: BiMap e TL.Text Text
_LTextText = iso TL.toStrict TL.fromStrict
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation! Turns out iso is actually useful 🙂

@chshersh chshersh merged commit cda93dd into master Jan 11, 2019
@chshersh chshersh deleted the vrom911/174-lazy-text branch January 11, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chshersh chshersh chshersh approved these changes

@sphaso sphaso Awaiting requested review from sphaso

@jiegillet jiegillet Awaiting requested review from jiegillet

@willbasky willbasky Awaiting requested review from willbasky

Assignees

@vrom911 vrom911

Labels
codec Conversion between TOML and custom user data types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vrom911 @chshersh