Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#270] Implement codecs for pair and triple #274

Merged
merged 1 commit into from
May 15, 2020
Merged

[#270] Implement codecs for pair and triple #274

merged 1 commit into from
May 15, 2020

Conversation

vrom911
Copy link
Member

@vrom911 vrom911 commented May 15, 2020

Resolves #270

@vrom911 vrom911 added the codec Conversion between TOML and custom user data types label May 15, 2020
@vrom911 vrom911 requested a review from chshersh as a code owner May 15, 2020 09:54
@vrom911 vrom911 self-assigned this May 15, 2020
hint-man[bot]
hint-man bot approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no place for me here... I will choose the truth I like.

chshersh
chshersh approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks super great! I especially appreciate great examples! And I also like that it will help with writing codecs for sum types.

@chshersh chshersh merged commit 0259670 into master May 15, 2020
@chshersh chshersh deleted the vrom911/270-Implement-codecs-for-pair-and branch May 15, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chshersh chshersh chshersh approved these changes

@hint-man hint-man[bot] hint-man approved these changes

Assignees

@vrom911 vrom911

Labels
codec Conversion between TOML and custom user data types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement codecs for pair and triple
2 participants
@vrom911 @chshersh