Add HLint #414
Open
Add HLint #414
+110
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrom911
reviewed
Oct 2, 2022
README.md
Outdated
| @@ -230,6 +230,14 @@ make it unique: | |||
| Haskell types and `htoml*` libraries use typeclasses-based approach | |||
| via `aeson` library. | |||
|
|
|||
| ## Development | |||
|
|
|||
| `iris` uses `hlint`, you can run it through: | |||
There was a problem hiding this comment.
I guess this name is from other PR 🙂
There was a problem hiding this comment.
I'm confused :x
I've pushed a fix.
vrom911
added
CI
vrom911
reviewed
Nov 2, 2022
| @@ -0,0 +1,76 @@ | |||
| # HLint configuration file | |||
There was a problem hiding this comment.
Is this the default file or some additional configurations were added here?
I think it is okay if we use the default one without adding the config file at all 🙂
|
@vrom911 is there anything I can do/improve to get it merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry for the unsolicited PR but I planned to do a hlint contribution on another repository and another contribution for this one and I mixed my folders :s
I push it so it could be useful eventually, and I'm going to make my contribution on this one as I planned to do.