[#8] Create EDSL for tomland #55
Conversation
src/Toml/Edsl.hs
Outdated
| type Env = State TOML () | ||
|
|
||
| toml :: Env -> TOML | ||
| toml env = execState env $ TOML mempty mempty |
There was a problem hiding this comment.
TOML mempty mempty appears multiple times across code... Maybe it's a good idea to create variable emptyToml?
src/Toml/Edsl.hs
Outdated
| toml env = execState env $ TOML mempty mempty | ||
|
|
||
| (=:) :: Key -> Value a -> Env | ||
| (=:) k v = modify $ \tml -> tml {tomlPairs = HashMap.insert k (AnyValue v) (tomlPairs tml)} |
There was a problem hiding this comment.
I see that this code has something in common with code in Bi.Combinators. Maybe you could write function with type like MonadSate TOML m => ... and reuse in all places?..
src/Toml/Edsl.hs
Outdated
|
|
||
| table :: Key -> Env -> Env | ||
| table k env = modify $ \tml -> tml | ||
| { tomlTables = Prefix.insert k (execState env (TOML mempty mempty)) (tomlTables tml) |
There was a problem hiding this comment.
execState env (TOML mempty mempty) looks like toml function you defined above!
examples/Playground.hs
Outdated
| "list" =: Array [String "one", String "two"] | ||
| "time" =: Array [Date $ Day (fromGregorian 2018 3 29)] | ||
| table "table.name.1" $ do | ||
| "aInner" =: Int 1 |
There was a problem hiding this comment.
I think I know how you can write key =: 1 instead of ke =: Int 1. Since we have GADT for Value, you can implement Num instance for Value 'TInt. And this will guarantee that it will be converted to Value using Int constructor. Also all pattern matchings will be exhaustive inside instance implementation because of that!
Same for IsString instance for Value. Not sure about IsList intsance, it probably will be impossible to implement... And, unfortunately, there's no IsBool type class in Haskell 😞
src/Toml/Edsl.hs
Outdated
| import qualified Data.HashMap.Strict as HashMap | ||
| import qualified Toml.PrefixTree as Prefix | ||
|
|
||
| type Env = State TOML () |
There was a problem hiding this comment.
Maybe it's better to name this type somehow else? Since it EDSL for creating toml, we could name it like TomlDsl or Tdsl or TDSL or something like that.
examples/Playground.hs
Outdated
| @@ -49,7 +48,7 @@ main = do | |||
| content <- TIO.readFile "test.toml" | |||
| case parse content of | |||
| Left (ParseException e) -> TIO.putStrLn e | |||
| Right toml -> TIO.putStrLn $ prettyToml toml | |||
| Right tml -> TIO.putStrLn $ prettyToml tml | |||
There was a problem hiding this comment.
Maybe toml is not the best name since if you export toml function you can't use toml as variable name? Maybe it's better to call it mkToml or declareTolm or defineToml to constructToml or createToml or something else? What do you think?
Resolves #8