Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keysWith and toListWith #106

Merged
merged 2 commits into from
Mar 14, 2021
Merged

Add keysWith and toListWith #106

merged 2 commits into from
Mar 14, 2021

Conversation

mniip
Copy link
Contributor

@mniip mniip commented Mar 11, 2021 •
edited

closes #105

@mniip
Copy link
Contributor Author

mniip commented Mar 11, 2021

keys is missing tests. Should I come up with some?

@int-index
Copy link
Collaborator

The code looks good, but tests are always welcome. Thanks!

@mniip mniip requested a review from int-index March 11, 2021 08:40
@int-index
Copy link
Collaborator

Looks like I don’t have merge permissions. In this case, @chshersh @vrom911 would you take a look at this patch, please?

vrom911
vrom911 approved these changes Mar 14, 2021
View reviewed changes
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vrom911 vrom911 merged commit 88b9ac5 into kowainik:main Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@int-index int-index int-index approved these changes

@vrom911 vrom911 vrom911 approved these changes

@chshersh chshersh Awaiting requested review from chshersh

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keys and kind erasure
3 participants
@mniip @int-index @vrom911