Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

76 fish details on hover #109

Open
wants to merge 17 commits into
base: development
Choose a base branch
from
Open

76 fish details on hover #109

wants to merge 17 commits into from

Conversation

AmboMaya
Copy link
Contributor

@AmboMaya AmboMaya commented Dec 4, 2018

Worked on popup feature when hover over each fish (name) on the main page.

  • I initially created FishDetailPopup component but came across issues when passing this component to
    the
  • Deleted and created inside the List Item of the
  • Resizing the popup window may still in a working progress as I spent too much time on this already

@AmboMaya
imported popup file
62bbc1a
@AmboMaya
Merge branch 'development' of https://github.com/kowhai-2018/fishlist …
df391e6 
…into 76-fishDetails-onHover
@AmboMaya
started popup
66dea5a
@AmboMaya
popup modal on <FishList> attempt one
8e940fa
@AmboMaya
Merge branch 'development' of https://github.com/kowhai-2018/fishlist …
0eb6ed3 
…into 76-fishDetails-onHover
@AmboMaya
Removed <Popup> from FishList , added FishDetailsPopup file,
00c8579 
removed export default at the bottom of Fish.jsx file
@AmboMaya
on Fish component:changed function to class, created event handler an…
4ab3a58 
…d updated render section. On FishDetailPop component: created a simple <Popup>
@AmboMaya
modified get function to add join table and specified table on select
bbbfced
@AmboMaya
added grid column to display image + description while hovering on link
04461a9
@AmboMaya
removed FishDetailPopup
f45f26d
@AmboMaya
merged conflicts
71f765e
@AmboMaya
Restore get function in db/fish.js
f9d052d
@AmboMaya
Add getById function to db/fish.js
30d888f
@AmboMaya
Modify get in db/fish.js to return all fish data
a8ebd72
@AmboMaya
made popup onhover work but popup sizing is still a working progress
eb29362
@AmboMaya
Merge branch 'development' of https://github.com/kowhai-2018/fishlist …
0f763be 
…into 76-fishDetails-onHover
@AmboMaya
need to pull latest changes from development
813d3ef
@emilyparkes emilyparkes self-assigned this Dec 4, 2018
@emilyparkes emilyparkes self-requested a review December 4, 2018 03:14
emilyparkes
emilyparkes requested changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@emilyparkes emilyparkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the test and it's all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilyparkes emilyparkes emilyparkes requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AmboMaya @emilyparkes