Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing code generator changes behavior of pyyaml #1825

Closed
gluap opened this issue Jan 30, 2024 · 0 comments · Fixed by #1826
Closed

Importing code generator changes behavior of pyyaml #1825

gluap opened this issue Jan 30, 2024 · 0 comments · Fixed by #1826

Comments

@gluap
Copy link
Contributor

gluap commented Jan 30, 2024

When importing datamodel_code_generator, the behaviour of pyyaml is changed after the import, datetime objects suddenly are deserialized from yaml as str whereas before they were deserialized as datetime objects.

Steps to reproduce:

create clean venv

python3 -m venv blub
blub/bin/pip install datamodel-code-generator pyyaml

Run this reproducer with the interpreter from the venv

import yaml
import tempfile
import datetime

tmp=tempfile.NamedTemporaryFile(mode='w')

def write_read():
    tmp=tempfile.NamedTemporaryFile(mode='w')
    yaml.safe_dump({"datetime": datetime.datetime.now()}, tmp)
    dumped_reloaded = yaml.safe_load(open(tmp.name,"r"))
    print(dumped_reloaded)

print("before importing datamodel-code-generator:")
write_read()

import datamodel_code_generator
print("\nafter importing datamodel-code-generator:")
write_read()

Actual output: (time string + object may change depending on run time)

before importing datamodel-code-generator:
{'datetime': datetime.datetime(2024, 1, 30, 9, 51, 19, 612368)}

after importing datamodel-code-generator:
{'datetime': '2024-01-30 09:51:20.019991'}

Expected output: (time string + object may change depending on run time):

before importing datamodel-code-generator:
{'datetime': datetime.datetime(2024, 1, 30, 9, 51, 19, 612368)}

after importing datamodel-code-generator:
{'datetime': datetime.datetime(2024, 1, 30, 9, 51, 20, 019991)}

The reason seems to be that the SafeLoader of yaml is modified globally by datamodel-code-generator

SafeLoader.yaml_constructors[

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant