Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop modifying behavior of yaml on load #1826

Merged
merged 6 commits into from Jan 30, 2024
Merged

Conversation

gluap
Copy link
Contributor

@gluap gluap commented Jan 30, 2024

Only modify a copy of SafeLoader to ensure that we don't change the behaviour of pyyaml for everyone.

Fixes #1825

gluap and others added 2 commits January 30, 2024 10:23
Only modify a copy of ``SafeLoader`` to ensure that we don't change the behaviour of ``pyyaml`` for everyone.
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@b4d6bf7). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1826   +/-   ##
=======================================
  Coverage        ?   98.98%           
=======================================
  Files           ?       37           
  Lines           ?     4153           
  Branches        ?      967           
=======================================
  Hits            ?     4111           
  Misses          ?       26           
  Partials        ?       16           
Flag Coverage Δ
unittests 98.67% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 30, 2024

CodSpeed Performance Report

Merging #1826 will not alter performance

Comparing gluap:patch-1 (c85287b) with main (b4d6bf7)

Summary

✅ 29 untouched benchmarks

gluap and others added 2 commits January 30, 2024 10:56
Try to address the CodeQL warning.
@gluap
Copy link
Contributor Author

gluap commented Jan 30, 2024

Note that CodeQL is happy now - the failing tests seem to be down to problems with the upload of coverage because the github workflow is missing a token to upload to codecov.io - likely unrelated to the content of the PR, as nothing in that direction has changed.

@koxudaxi
Copy link
Owner

@gluap
Thank you for creating the PR.
you are right. we should copy it.

Note that CodeQL is happy now - the failing tests seem to be down to problems with the upload of coverage because the github workflow is missing a token to upload to codecov.io - likely unrelated to the content of the PR, as nothing in that direction has changed.

OK, I will fix it to merge the PR.

@koxudaxi koxudaxi merged commit 480779e into koxudaxi:main Jan 30, 2024
88 checks passed
@gluap gluap deleted the patch-1 branch January 30, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing code generator changes behavior of pyyaml
2 participants