Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove self attribute from jsonschema root attributes #1318

Merged
merged 1 commit into from
Jun 3, 2023

Conversation

rezen
Copy link
Contributor

@rezen rezen commented May 12, 2023

Fixes issue found here #1317

@rezen rezen changed the title Remove self attribute from jsonschema root attributes 1317 Remove self attribute from jsonschema root attributes May 12, 2023
@rezen rezen changed the title 1317 Remove self attribute from jsonschema root attributes Remove self attribute from jsonschema root attributes May 12, 2023
@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e9b6edf) 100.00% compared to head (3431957) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #1318     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           11        25     +14     
  Lines         1020      3260   +2240     
  Branches       201       780    +579     
===========================================
+ Hits          1020      3260   +2240     
Flag Coverage Δ
unittests 99.93% <99.92%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datamodel_code_generator/__init__.py 100.00% <100.00%> (ø)
datamodel_code_generator/__main__.py 100.00% <100.00%> (ø)
datamodel_code_generator/format.py 100.00% <100.00%> (ø)
datamodel_code_generator/http.py 100.00% <100.00%> (ø)
datamodel_code_generator/imports.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/__init__.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/base.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/dataclass.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/enum.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/improts.py 100.00% <100.00%> (ø)
... and 15 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koxudaxi koxudaxi merged commit ff48158 into koxudaxi:master Jun 3, 2023
43 checks passed
@koxudaxi
Copy link
Owner

koxudaxi commented Jun 6, 2023

@rezen
I have released the new version as 0.20.0
Thank you very much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants