Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for model wise base classes #1350

Merged

Conversation

senesh-deshan
Copy link
Contributor

Added support for model wise base classes with customBasePath keyword in JsonSchemaObject.
It allows user to specify a custom base class per each generated model where as existing base_class argument is dedicated for specifying a single base class for all the models generated.

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e9b6edf) 100.00% compared to head (2ed2d62) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #1350     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           11        26     +15     
  Lines         1020      3335   +2315     
  Branches       201       792    +591     
===========================================
+ Hits          1020      3335   +2315     
Flag Coverage Δ
unittests 99.94% <99.92%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datamodel_code_generator/__init__.py 100.00% <100.00%> (ø)
datamodel_code_generator/__main__.py 100.00% <100.00%> (ø)
datamodel_code_generator/format.py 100.00% <100.00%> (ø)
datamodel_code_generator/http.py 100.00% <100.00%> (ø)
datamodel_code_generator/imports.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/__init__.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/base.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/dataclass.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/enum.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/improts.py 100.00% <100.00%> (ø)
... and 16 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koxudaxi koxudaxi merged commit de04565 into koxudaxi:master Jun 5, 2023
43 checks passed
@koxudaxi
Copy link
Owner

koxudaxi commented Jun 6, 2023

@senesh-deshan
I have released the new version as 0.20.0
Thank you very much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants