Relax version constraint of prance #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1409 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 11 32 +21
Lines 1020 3540 +2520
Branches 201 831 +630
===========================================
+ Hits 1020 3540 +2520
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
@tetsuok |
|
@koxudaxi Thank you for merging the pull request, and quickly releasing 0.21.1 at PyPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes relaxing the version constraint of prance (https://pypi.org/project/prance/). This is to avoid transitive dependency issues caused by prance: Currently, users can't use this fantastic datamodel-code-generator along with Python packages that require packaging 22.0 or newer.
One example of such packages is Black: Black 23.1.0 or newer require packaging 22.0 or newer (commit) (NOTE: in organizations that adopt monorepo, they often need to use a single centralized requirements file that contain Black and datamodel-code-generator that require different versions of packaging).
There are two reasons why the dependency issue happens:
packaging~=21.3until prance 0.22.11.4.0. This version constraint was relaxed for prance 23.06.21.0. Note that prance changed the versioning scheme recently.A solution to the issues would be to relax the version constraint of prance so that users can install prance 23.06.21.0.