Fix Pydantic V2 RootModel inheritance #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Pydantic V2, root models are defined by inheriting RootModel class and defining the root field.
for more information, see https://pre-commit.ci
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1477 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 11 32 +21
Lines 1020 3569 +2549
Branches 201 838 +637
===========================================
+ Hits 1020 3569 +2549
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
barreeeiroo
force-pushed
the
fix/pydantic-v2-rootmodel
branch
from
d4879b7
to
d85fafb
Compare
TypedDict is not available on pre-3.8, so changing this to Any to avoid issues...
|
Well, now all the tests are passing but the Codecov step is failing because the GitHub Actions tests run before code coverage was reported and a 404 error was raised from the test action. |
|
I have cleared CI chache and re-invoke actions. |
|
Thank you very much!! |
You're welcome! Thank you very much for this amazing tool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Pydantic V2, root models are defined by inheriting
RootModelclass and defining therootfield. However, in Pydantic V1, root models were defined by inheriting the sameBaseModeland declaring a__root__field.Developers can set the
base_classparameter to override the inherited class in the generated models. For Pydantic V1, this works fine in all cases as both Normal Models and Root Models were inheriting the same class. But for Pydantic V2 Root Models need to inherit a different class, so having the samebase_classfor both Normal Models and Root Models no longer works (as Root Models will be detected as Normal Models with a literalrootfield).Considering how Enum's are being generated (by ignoring
base_class), it seems like the best approach is the same one: for Pydantic V2 Root Models, ignore ifbase_classis set and always inheritRootModel. This PR applies this change for Pydantic V2 Root Models only.Fixes #1435 (kinda, see #1435 (comment))