-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch away from deprecated pydantic method #1485
switch away from deprecated pydantic method #1485
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1485 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 11 32 +21
Lines 1020 3579 +2559
Branches 201 839 +638
===========================================
+ Hits 1020 3579 +2559
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Thank you for creating PR. datamodel-code-generator/datamodel_code_generator/parser/jsonschema.py Lines 164 to 175 in 24bb074
|
@koxudaxi done, lmk if that's ok |
hmm, looks like I missed something... |
@iliakur Thank you very much!! |
@koxudaxi Thanks for the final tweaks! qq: when do you think this will be released? |
@iliakur |
oh, this is great, thanks a bunch for such a quick release!! |
I'm starting with just one method conversion to get initial feedback and check tests, but there's also one lurking in
types.py
which I'll convert later in the same PR.