fix: add type parameters to generic RootModel #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes mypy's error: Missing type parameters for generic type 'RootModel'
tcrasset
force-pushed
the
tc/fix-pydanticv2-RootModel-mypy-error
branch
from
d15e132
to
80b4782
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1560 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 11 33 +22
Lines 1020 3621 +2601
Branches 201 841 +640
===========================================
+ Hits 1020 3621 +2601
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Hi @koxudaxi, the CI seems to fail only due to the code coverage report not succeeding to upload. The tests seem to pass. |
|
@tcrasset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1491
and by extension it fixes mypy's error:
Missing type parameters for generic type 'RootModel'It's not clear from the pydantic documentation whether they force the user to use declare the type twice. They have one example with
Pets(RootModel[List[str]])and one withPets(RootModel). Thoughmypyseems to be in favor of the double type hint style.