Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python3.6 support #887

Merged
merged 7 commits into from
Nov 6, 2022
Merged

Drop python3.6 support #887

merged 7 commits into from
Nov 6, 2022

Conversation

koxudaxi
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (b47f6a6) compared to base (e9b6edf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##            master      #887     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           11        14      +3     
  Lines         1020      2066   +1046     
  Branches       201       435    +234     
===========================================
+ Hits          1020      2066   +1046     
Flag Coverage Δ
unittests 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datamodel_code_generator/__main__.py 100.00% <100.00%> (ø)
datamodel_code_generator/http.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/base.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/enum.py 100.00% <100.00%> (ø)
...amodel_code_generator/model/pydantic/base_model.py 100.00% <100.00%> (ø)
..._code_generator/model/pydantic/custom_root_type.py 100.00% <100.00%> (ø)
...tamodel_code_generator/model/pydantic/dataclass.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/pydantic/imports.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/pydantic/types.py 100.00% <100.00%> (ø)
datamodel_code_generator/parser/base.py 100.00% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gjcarneiro
Copy link
Contributor

I am working on a code base that runs onpython 3.6 still, and will not upgrade for some time. Is the intention to have the code generator itself require python >= 3.7 but generates code that still works on python 3.6? Or is the generated code no longer going to support 3.6?

@koxudaxi
Copy link
Owner Author

koxudaxi commented Nov 2, 2022

@gjcarneiro

Is the intention to have the code generator itself require python >= 3.7
Some libraries drop Python 3.6 support.
I don't want to keep complex dependency.

Also, I checked the download list.
I think Python 3.6 users are decreasing now.

but generates code that still works on python 3.6? Or is the generated code no longer going to support 3.6?

I would remove string annotation features like Optional['OriginalModel'] for Python3.6

But, If a few users need Python 3.6 support.
I will close the PR.

@gjcarneiro
Copy link
Contributor

Would be great if you could generate code still compatible with Python 3.6, even if it needs to run on Python >= 3.7 now. But it's your call. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants