Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generating import statement code #893

Merged
merged 2 commits into from
Nov 4, 2022
Merged

Fix generating import statement code #893

merged 2 commits into from
Nov 4, 2022

Conversation

antxln
Copy link
Contributor

@antxln antxln commented Nov 2, 2022

Reference: #892

Code generator is appending a dot at end of module name in import statement, which is throwing an error with black. Maybe the dot can be prepended since it is indicating path heirarchy levels?

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (9753f7b) compared to base (e9b6edf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##            master      #893     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           11        14      +3     
  Lines         1020      2047   +1027     
  Branches       201       474    +273     
===========================================
+ Hits          1020      2047   +1027     
Flag Coverage Δ
unittests 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datamodel_code_generator/__main__.py 100.00% <100.00%> (ø)
datamodel_code_generator/http.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/base.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/enum.py 100.00% <100.00%> (ø)
...amodel_code_generator/model/pydantic/base_model.py 100.00% <100.00%> (ø)
..._code_generator/model/pydantic/custom_root_type.py 100.00% <100.00%> (ø)
...tamodel_code_generator/model/pydantic/dataclass.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/pydantic/imports.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/pydantic/types.py 100.00% <100.00%> (ø)
datamodel_code_generator/parser/base.py 100.00% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koxudaxi koxudaxi merged commit df88011 into koxudaxi:master Nov 4, 2022
@koxudaxi
Copy link
Owner

koxudaxi commented Nov 8, 2022

@antxln
Thank you for creating the PR.
I have released a new version as 0.13.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants