add custom variables support #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@koxudaxi just making sure this is on your radar. |
koxudaxi
force-pushed
the
custom-template-variables
branch
from
8adda35
to
7b29afa
Compare
Codecov ReportBase: 92.43% // Head: 91.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #247 +/- ##
==========================================
- Coverage 92.43% 91.01% -1.43%
==========================================
Files 2 5 +3
Lines 291 345 +54
==========================================
+ Hits 269 314 +45
- Misses 22 31 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@sofianhnaide |
|
Thank you 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool was a great starting point for us to generate different targets based on the OpenAPI definition. We found that with custom templates we were able to get 90% of the way there, but we need to add the support for custom variables.
This is a draft PR to see if this is a direction you want go, I still need to add/fix some tests and refine docs. The proposal should be simple and covered in the readme. Looking forward to hear your thoughts :)