Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests - Issue #260 #266

Merged
merged 1 commit into from Jul 26, 2022
Merged

Fix tests - Issue #260 #266

merged 1 commit into from Jul 26, 2022

Conversation

jcarlosgalvezm
Copy link
Contributor

No description provided.

@jcarlosgalvezm
Copy link
Contributor Author

Hi @koxudaxi can you have a look to this PR?

Actually the tests are broken in the master branch, it causes the dependanbot PR fails leaving the library obsolete in terms of the version of its dependencies.

I would appreciate it if you could review it so that it could be corrected.

Best Regards,
Carlos

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #266 (a9c3b77) into master (68dfe2e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   92.43%   92.43%           
=======================================
  Files           2        2           
  Lines         291      291           
=======================================
  Hits          269      269           
  Misses         22       22           
Flag Coverage Δ
unittests 92.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408a2ad...a9c3b77. Read the comment docs.

@koxudaxi koxudaxi merged commit 2df5bc1 into koxudaxi:master Jul 26, 2022
@koxudaxi
Copy link
Owner

@jcarlosgalvezm
Thank you very much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants