Added option for inputting encoding of file #334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now you can also give --encoding or -e option to indicate the encoding of input file
for more information, see https://pre-commit.ci
|
I'm trying to merge the the change to the latest master on https://github.com/yyamano/fastapi-code-generator/tree/issue-334 @mmzeynalli @koxudaxi I want to hear your opinion about default encoding. I don't think cp1252 is a good default value. utf-8 or platform default encoding (utf-8 on linux, shift_jis on japanese version of windows, etc) is better. Python's platform default encoding on Windows is changing by PEP 686. What are your thoughts on this? |
yyamano
added a commit
to yyamano/fastapi-code-generator
that referenced
this pull request
Aug 23, 2023
cp1252 is a superset of iso-8859-1. I don't think it is a good default value. See koxudaxi#334 (comment) Fixed koxudaxi#334
|
@yyamano |
koxudaxi
added a commit
that referenced
this pull request
Sep 7, 2023
Fixed broken test (Added option for inputting encoding of file #334)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can also give --encoding or -e option to indicate the encoding of input file