Add support for binary types (#89)

* Add support for binary types Fixes #88 * Ignore coverage Co-authored-by: Koudai Aono <koxudaxi@gmail.com>
koxudaxi · Mar 5, 2021 · c737eec · c737eec
1 parent 2c58206
commit c737eec
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/local_data_api/resources/jdbc/__init__.py b/local_data_api/resources/jdbc/__init__.py
@@ -94,6 +94,8 @@ def get_filed_from_jdbc_type(self, value: Any, jdbc_type: Optional[int]) -> Fiel
             elif type_ in BOOLEAN:
                 return Field(booleanValue=value)
             elif type_ in BLOB:
+                if isinstance(value, str):  # pragma: no cover
+                    value = value.encode()
                 return Field(blobValue=b64encode(value))
 
         return self.get_field_from_value(value)

diff --git a/scripts/integration-test.sh b/scripts/integration-test.sh
@@ -58,6 +58,15 @@ function test {
         --include-result-metadata \
         --sql 'SELECT 1 > 0 AS value' \
         | jq -e '.records[0][0].booleanValue == true'
+
+        aws rds-data execute-statement \
+        --endpoint-url 'http://localhost:8080' \
+        --database 'test' \
+        --resource-arn $RDS_DATA_API_CLIENT_RESOURCE_ARN \
+        --secret-arn $RDS_DATA_API_CLIENT_SECRETARN \
+        --include-result-metadata \
+        --sql $'SELECT \'hello\'::bytea as value' \
+        | jq -e '.records[0][0].blobValue == "aGVsbG8="'
     fi
 
     # select boolean (mysql)
@@ -72,6 +81,15 @@ function test {
         --include-result-metadata \
         --sql 'SELECT 1 > 0 AS value' \
         | jq -e '.records[0][0].longValue == 1'
+
+        aws rds-data execute-statement \
+        --endpoint-url 'http://localhost:8080' \
+        --database 'test' \
+        --resource-arn $RDS_DATA_API_CLIENT_RESOURCE_ARN \
+        --secret-arn $RDS_DATA_API_CLIENT_SECRETARN \
+        --include-result-metadata \
+        --sql $'SELECT BINARY \'hello\' as value' \
+        | jq -e '.records[0][0].blobValue == "aGVsbG8="'
     fi
 
     aws rds-data execute-statement \