Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed support for PostgresSQL without JDBC #59

Merged
merged 3 commits into from
Apr 23, 2020

Conversation

Apoalex92
Copy link
Contributor

Hello!
I have completed the support for PostgreSQL without using JDBC (just a basic configuration).
In my case, it solves the issue #50.

I have updated the settings part in which the appropriate database engine is selected.

For further works it would be great to add more details to the ColumnMetadata infos

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #59   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          620       629    +9     
  Branches        75        77    +2     
=========================================
+ Hits           620       629    +9     
Impacted Files Coverage Δ
local_data_api/models.py 100.00% <100.00%> (ø)
local_data_api/resources/postgres.py 100.00% <100.00%> (ø)
local_data_api/settings.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19e9274...c035e99. Read the comment docs.

@koxudaxi
Copy link
Owner

@Apoalex92
Thank you for creating your PR.
Looks Good!!
Would you please add a unittest for covering your code?
I want to make coverage 100%.

@Apoalex92
Copy link
Contributor Author

Sure! Sorry for not doing it before :)

@Apoalex92
Copy link
Contributor Author

@koxudaxi It's done!

@koxudaxi koxudaxi merged commit 5e6ee17 into koxudaxi:master Apr 23, 2020
@koxudaxi
Copy link
Owner

@Apoalex92
Looks good!
I have merged and released a new version as 0.4.10.

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants