Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong an error for a duplicate in config. #297

Merged
merged 2 commits into from May 13, 2021

Conversation

koxudaxi
Copy link
Owner

Related Issues

#296

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #297 (4d9a741) into master (1c115c1) will decrease coverage by 0.06%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #297      +/-   ##
============================================
- Coverage     72.86%   72.80%   -0.07%     
- Complexity      274      277       +3     
============================================
  Files            23       23              
  Lines          1618     1629      +11     
  Branches        482      486       +4     
============================================
+ Hits           1179     1186       +7     
  Misses          166      166              
- Partials        273      277       +4     
Flag Coverage Δ Complexity Δ
unittests 72.80% <81.81%> (-0.07%) 277.00 <4.00> (+3.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/com/koxudaxi/pydantic/Pydantic.kt 74.70% <66.66%> (-0.20%) 0.00 <0.00> (ø)
src/com/koxudaxi/pydantic/PydanticCacheService.kt 58.06% <72.72%> (ø) 12.00 <4.00> (?)
...koxudaxi/pydantic/PydanticCompletionContributor.kt 85.04% <100.00%> (ø) 1.00 <0.00> (ø)
src/com/koxudaxi/pydantic/PydanticInspection.kt 76.97% <100.00%> (ø) 2.00 <0.00> (ø)
...oxudaxi/pydantic/PydanticPackageManagerListener.kt 69.23% <100.00%> (ø) 3.00 <0.00> (ø)
src/com/koxudaxi/pydantic/PydanticTypeProvider.kt 75.05% <100.00%> (ø) 137.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 738fb31...4d9a741. Read the comment docs.

@koxudaxi koxudaxi merged commit b7b734c into master May 13, 2021
@koxudaxi koxudaxi deleted the fix_wrong_an_error_for_a_duplicate_in_config branch May 13, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant