Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong call parameters when init is defined #298

Merged
merged 2 commits into from May 13, 2021
Merged

Fix wrong call parameters when init is defined #298

merged 2 commits into from May 13, 2021

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented May 13, 2021 •
edited

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #298 (f6a5e70) into master (4d9a741) will increase coverage by 0.12%.
The diff coverage is 78.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #298      +/-   ##
============================================
+ Coverage     72.80%   72.92%   +0.12%     
- Complexity      277      280       +3     
============================================
  Files            23       23              
  Lines          1629     1640      +11     
  Branches        486      493       +7     
============================================
+ Hits           1186     1196      +10     
  Misses          166      166              
- Partials        277      278       +1
Flag Coverage Δ Complexity Δ
unittests 72.92% <78.57%> (+0.12%) 280.00 <0.00> (+3.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/com/koxudaxi/pydantic/Pydantic.kt 74.41% <71.42%> (-0.29%) 0.00 <0.00> (ø)
src/com/koxudaxi/pydantic/PydanticTypeProvider.kt 75.58% <83.33%> (+0.52%) 140.00 <0.00> (+3.00)
...koxudaxi/pydantic/PydanticCompletionContributor.kt 85.11% <100.00%> (+0.06%) 1.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7b734c...f6a5e70. Read the comment docs.

@koxudaxi koxudaxi merged commit 77e8aab into master May 13, 2021
@koxudaxi koxudaxi deleted the fix_wrong_call_parameters_when_init_is_defined branch May 13, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@koxudaxi