Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive detection of "extra fields not permitted" #368

Merged

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented Sep 6, 2021

Related Issues

#367

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #368 (7c6ef75) into master (b81e78c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #368      +/-   ##
============================================
+ Coverage     73.19%   73.21%   +0.01%     
  Complexity      283      283              
============================================
  Files            23       23              
  Lines          1679     1680       +1     
  Branches        509      510       +1     
============================================
+ Hits           1229     1230       +1     
  Misses          166      166              
  Partials        284      284              
Flag Coverage Δ
unittests 73.21% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/com/koxudaxi/pydantic/PydanticInspection.kt 78.75% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd5b608...7c6ef75. Read the comment docs.

@koxudaxi koxudaxi merged commit 7f23b5c into master Sep 6, 2021
@koxudaxi koxudaxi deleted the fix_false_positive_detection_of_extra_fields_not_permitted branch September 6, 2021 11:01
@finswimmer
Copy link

This was fast 🚀 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants